Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing order of buttons in Bottom App Bar #226

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

anuragkanojiya1
Copy link
Contributor

@anuragkanojiya1 anuragkanojiya1 commented Oct 2, 2024

Related Issue

Closes: #187

Description

Changed the order of buttons in the Bottom App Bar of FoodExpirationDates project.

Copy link
Owner

@lorenzovngl lorenzovngl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you for your contribution!
I reviewed your changes. They are ok but are not enoght to accept the work as finished.
As you can see in the video below, the behavior is not good.

Registrazione.dello.schermo.2024-10-05.162559.mp4

Take a look at this code: you need to adapt it to the new order.
Also, please remember to test your changes before submitting pull requests.

var selectedItem = when (currentDestination) {
Screen.AboutScreen.route -> 0
Screen.SettingsScreen.route -> 2
else -> 1
}

And please remove these files from your commit:
image

If you have troubles with something, I can help you 🙂

@anuragkanojiya1
Copy link
Contributor Author

Hello and thank you for your contribution! I reviewed your changes. They are ok but are not enoght to accept the work as finished. As you can see in the video below, the behavior is not good.

Registrazione.dello.schermo.2024-10-05.162559.mp4
Take a look at this code: you need to adapt it to the new order. Also, please remember to test your changes before submitting pull requests.

var selectedItem = when (currentDestination) {
Screen.AboutScreen.route -> 0
Screen.SettingsScreen.route -> 2
else -> 1
}

And please remove these files from your commit: image

If you have troubles with something, I can help you 🙂

Okay sure, going to work on it now.

@anuragkanojiya1
Copy link
Contributor Author

anuragkanojiya1 commented Oct 5, 2024

@lorenzovngl Task is Done.

You can check it out in this video below :

clideo_editor_14e038f826b14dd49c5019eec1610e5c.mp4

@lorenzovngl
Copy link
Owner

All good! Thank you for your contribution! 😁🎉

@lorenzovngl lorenzovngl merged commit 39b68ed into lorenzovngl:main Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change order of options.
2 participants