-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing order of buttons in Bottom App Bar #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thank you for your contribution!
I reviewed your changes. They are ok but are not enoght to accept the work as finished.
As you can see in the video below, the behavior is not good.
Registrazione.dello.schermo.2024-10-05.162559.mp4
Take a look at this code: you need to adapt it to the new order.
Also, please remember to test your changes before submitting pull requests.
Lines 52 to 56 in fb5c302
var selectedItem = when (currentDestination) { | |
Screen.AboutScreen.route -> 0 | |
Screen.SettingsScreen.route -> 2 | |
else -> 1 | |
} |
And please remove these files from your commit:
If you have troubles with something, I can help you 🙂
Okay sure, going to work on it now. |
@lorenzovngl Task is Done. You can check it out in this video below : clideo_editor_14e038f826b14dd49c5019eec1610e5c.mp4 |
All good! Thank you for your contribution! 😁🎉 |
Related Issue
Closes: #187
Description
Changed the order of buttons in the Bottom App Bar of FoodExpirationDates project.