Fix background colors in App Bars #230 #236
Conversation
There was a problem hiding this comment.
It was more difficult than expected to figure out why this bug has appeared.
Regarding TopAppBar, you're right. I'm sorry for not providing a meaningful screenshot. Please fix it as described here:
navigationIcon = navigationIcon,
- scrollBehavior = scrollBehavior
+ scrollBehavior = scrollBehavior,
+ colors = TopAppBarDefaults.topAppBarColors(
+ scrolledContainerColor = MaterialTheme.colorScheme.surfaceColorAtElevation(TonalElevation.level2())
+ )
)
}| @@ -6,7 +6,7 @@ val md_theme_light_primary = Color(0xFF934B00) | |||
| val md_theme_light_onPrimary = Color(0xFFFFFFFF) | |||
| val md_theme_light_primaryContainer = Color(0xFFFFDCC5) | |||
| val md_theme_light_onPrimaryContainer = Color(0xFF301400) | |||
| val md_theme_light_secondary = Color(0xFF755945) | |||
| val md_theme_light_secondary = Color(0xFF755945)// | |||
There was a problem hiding this comment.
Has this been included in the commit by mistake?
| @@ -23,7 +23,7 @@ val md_theme_light_onBackground = Color(0xFF201A17) | |||
| val md_theme_light_surface = Color(0xFFFFFBFF) | |||
| val md_theme_light_onSurface = Color(0xFF201A17) | |||
| val md_theme_light_surfaceVariant = Color(0xFFF3DFD2) | |||
| val md_theme_light_onSurfaceVariant = Color(0xFF52443B) | |||
| val md_theme_light_onSurfaceVariant = Color(0xFF52443B)// | |||
There was a problem hiding this comment.
Has this been included in the commit by mistake?
| @@ -38,7 +38,7 @@ val md_theme_dark_onPrimary = Color(0xFF4F2500) | |||
| val md_theme_dark_primaryContainer = Color(0xFF703800) | |||
| val md_theme_dark_onPrimaryContainer = Color(0xFFFFDCC5) | |||
| val md_theme_dark_secondary = Color(0xFFE4BFA7) | |||
| val md_theme_dark_onSecondary = Color(0xFF422B1A) | |||
| val md_theme_dark_onSecondary = Color(0xFF422B1A)// | |||
There was a problem hiding this comment.
Has this been included in the commit by mistake?
There was a problem hiding this comment.
ohh yeah sorry it was by mistake
| @@ -63,7 +63,7 @@ private val DarkColors = darkColorScheme( | |||
| surfaceVariant = md_theme_dark_surfaceVariant, | |||
| onSurfaceVariant = md_theme_dark_onSurfaceVariant, | |||
| outline = md_theme_dark_outline, | |||
| inverseOnSurface = md_theme_dark_inverseOnSurface, | |||
| inverseOnSurface = md_theme_light_inverseSurface, | |||
There was a problem hiding this comment.
Please don't modify this file. Also, this is incorrect: why assigning a light-themed color to a dark-themed variable?
There was a problem hiding this comment.
ohh my bad I was changing the color to see the matching bottom bar color.
| @@ -48,7 +49,7 @@ fun MyBottomAppBar( | |||
| unselectedIcon = Icons.Outlined.Info | |||
| ) | |||
| ) | |||
| NavigationBar { | |||
| NavigationBar(containerColor = MaterialTheme.colorScheme.inverseOnSurface) { | |||
There was a problem hiding this comment.
It's correct to change containerColor, but please assign the following value:
| NavigationBar(containerColor = MaterialTheme.colorScheme.inverseOnSurface) { | |
| NavigationBar( | |
| containerColor = MaterialTheme.colorScheme.surfaceColorAtElevation(TonalElevation.level2()) | |
| ) { |
There was a problem hiding this comment.
It was more difficult than expected to figure out why this bug has appeared.
Regarding TopAppBar, you're right. I'm sorry for not providing a meaningful screenshot. Please fix it as described here:
navigationIcon = navigationIcon, - scrollBehavior = scrollBehavior + scrollBehavior = scrollBehavior, + colors = TopAppBarDefaults.topAppBarColors( + scrolledContainerColor = MaterialTheme.colorScheme.surfaceColorAtElevation(TonalElevation.level2()) + ) ) }
Please add this change reported above to fix colors also in TopAppBar, and remove the changes I requested to remove on the previous review.
Thank you
|
Okay I will do it. |
|
I have made the changes please do check |
|
All good! Thank you for your efforts and welcome among the contributors of Food Expiration Dates! 🎉 |
|
Thank you @lorenzovngl once again, without your help I couldn't do. |
I made some changes in the Material Theme and added containerColor parameter for the NavigationBar to fix the background color issue, but for the TopAppBar I don't see any differences in the screenshots you uploaded.
If there's any changes you want to make or anything wrong with what I did, please do tell me.