-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Screen Protection feature #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a very good work, congratulations!
However, even the feature works, it's important to keep the code clean and consistent. I have marked some changes that you should apply.
Maybe, after these changes, I will suggest some further ones, but let's move step by step.
app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/screen/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/screen/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
@lorenzovngl I've made the requested changes. If there are some other changes, please enlighten me. 😊 |
app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/screen/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
@lorenzovngl I have made all the necessary changes. Check it out! ✨ |
Amazing work! Congratulations and thank you for your valuable contribution! 🎉 |
Thank you so much! It’s been an absolute pleasure contributing to this project. Your guidance and well-structured codebase made it easy to jump in and feel empowered to add value. I'm thrilled to see how this project continues to grow, and I’m excited to be part of it. Looking forward to more opportunities to collaborate and build together! 🚀 |
Related Issue
Closes #218
Description
This PR implements a screen protection feature that disables screenshots and screen recording when the user enables the corresponding switch in the app settings. When activated, the app will prevent any form of screen capture for enhanced security. This feature can be toggled by the user and takes effect immediately upon switching.
Type of change
When I enable the Screen Protection, app automatically prevent all the screen captures functions like screenshots and screen recording.
24-10-20-03-29-23.mp4