-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Memory cache off-by-one error (#396)
* Fixes an off by one in the handling of the in memory cache, which also caused it to blow up if cache size == 0 * Fixed InfoCache getter bypassing size restrictions of the RAM cache and actually remedied the issues with the RAM cache size == 0 case, as I thought I had in the previous commit. Added tests for these cases. * Minor effeciency improvement - only read from disk once in the case where none of the info is cached in RAM. Still does two disk reads in all cases where RAM cache size > 0 * per conversation with @bcail in #396 - Avoiding writing to disk on every get()
- Loading branch information
Showing
2 changed files
with
73 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters