Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory cache off-by-one error #396

Merged
merged 4 commits into from
Feb 13, 2018
Merged

Memory cache off-by-one error #396

merged 4 commits into from
Feb 13, 2018

Commits on Feb 12, 2018

  1. Fixes an off by one in the handling of the in memory cache, which als… 

    …o caused it to blow up if cache size == 0
    brian committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    615e3bb View commit details
    Browse the repository at this point in the history

  2. Fixed InfoCache getter bypassing size restrictions of the RAM cache a… 

    …nd actually remedied the issues with the RAM cache size == 0 case, as I thought I had in the previous commit. Added tests for these cases.
    brian committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    2e9ad5f View commit details
    Browse the repository at this point in the history

  3. Minor effeciency improvement - only read from disk once in the case w… 

    …here none of the info is cached in RAM. Still does two disk reads in all cases where RAM cache size > 0
    brian committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    96e54e9 View commit details
    Browse the repository at this point in the history

  4. per conversation with @bcail in #396 - Avoiding writing to disk on ev… 

    …ery get()
    brian committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    a02fcca View commit details
    Browse the repository at this point in the history