Fix subclassing deprecated classes #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@technoweenie can you review this since the issues are trickling in |
olleolleolle
approved these changes
Sep 28, 2019
BobbyMcWho
force-pushed
the
fix-subclassing-deprecated-classes
branch
from
429f899 to
f8a8312
Compare
|
@olleolleolle Squashed to 1 commit |
The version modeled off of activesupport's deprecations methods was causing issues when classes inherited from the deprecated class. Switch to a metaprogrammed class that warns upon initialization. Failing spec for lostisland#1033 rename module to DeprecatedClass Fix incorrect usage of rspec raise_error WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the expectation to pass, including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError), meaning the code you are intending to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`. Update class doc
BobbyMcWho
force-pushed
the
fix-subclassing-deprecated-classes
branch
from
f8a8312 to
c90dfb5
Compare
|
Updated the class doc |
|
Thanks for the repairs! |
|
@olleolleolle do you know when you're going to release this to rubygems? |
|
No, I don't know – currently traveling. |
BobbyMcWho
added a commit
to BobbyMcWho/faraday
that referenced
this pull request
Sep 30, 2019
The version modeled off of activesupport's deprecations methods was causing issues when classes inherited from the deprecated class. Switch to a metaprogrammed class that warns upon initialization. Failing spec for lostisland#1033 rename module to DeprecatedClass Fix incorrect usage of rspec raise_error WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the expectation to pass, including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError), meaning the code you are intending to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`. Update class doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation didn't work because it was setting the constant to an instance of
DeprecatedConstantwhich wasn't a class, so therefore couldn't be subclassed.Feel free to critique my implementation and make any suggestions you see fit.
Fixes #1033