Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1x deprecate fixes 2 #1076

Merged
merged 4 commits into from
Nov 20, 2019
Merged

0.1x deprecate fixes 2 #1076

merged 4 commits into from
Nov 20, 2019

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Nov 14, 2019

Fixes some minor issues with the deprecate stuff that I found while trying to port this to the master branch.

  1. Fix rubocop compliant about ===
  2. Refactor DeprecatedClass.proxy_class so it can accept any version. Bonus: now that the klass_name is not built in an isolated metaclass scope, it can just use the method's origclass argument for the replacement messages, without regexes.
  3. Use a shared Gem::Version instance in wrappers around deprecated methods.

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simplified and easier to maintain solution. Evolving! Still as good, too.

@technoweenie
Copy link
Member Author

@BobbyMcWho: Do you have any thoughts on these changes to the Deprecate code? I want to port it to the master branch, so I need #proxy_class to accept a ver argument.

@BobbyMcWho
Copy link
Contributor

BobbyMcWho commented Nov 14, 2019

@technoweenie minor changes I propose in #1077, overall great changes you've proposed!

@technoweenie
Copy link
Member Author

Thanks @BobbyMcWho. I like the nested PR trick too :)

@technoweenie technoweenie merged commit 389ede4 into 0.1x Nov 20, 2019
@technoweenie technoweenie deleted the 0.1x-deprecate-fixes-2 branch November 20, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants