Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.9 syntax error #1086

Closed
wants to merge 3 commits into from
Closed

Fix 1.9 syntax error #1086

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b5b028
Fix 1.9 syntax error
BanzaiMan Dec 10, 2019
c7d56a7
Fix CI for Ruby 2.3
mrexox Dec 10, 2019
804f8ff
Merge branch '0.1x' into patch-1
iMacTia Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/faraday/error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def initialize(exc = 'timeout', response = nil)

# Raised by Faraday::Response::RaiseError in case of a nil status in response.
class NilStatusError < ServerError
def initialize(_exc, response: nil)
def initialize(_exc, response = nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is NOT the same thing as def initialize(_exc, response: nil)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's true. However, I will point out that this is the same call signature as that of TimeoutError on line 80. If this is not the right way, then TimeoutError should also be revisited.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be rewritten to accept a hash parameter? Like that:

def initialize(_exc, params)
  response = params[:response]

message = 'http status could not be derived from the server response'
super(message, response)
end
Expand Down