Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.0 release to wording in CONTRIBUTING #1155

Merged
merged 2 commits into from
May 7, 2020
Merged

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented May 5, 2020

Description

This PR updates the CONTRIBUTING document to reflect the fact that v1.0 has been released.

Unrelated: One thing that stood out to me was the policy of accepting new middleware. That seems like an outdated policy?

I came across this while preparing to copy content to the faraday-http project, to support lostisland/faraday-http#14

@olleolleolle olleolleolle requested a review from iMacTia May 5, 2020 19:42
@iMacTia
Copy link
Member

iMacTia commented May 7, 2020

One thing that stood out to me was the policy of accepting new middleware. That seems like an outdated policy?

Yes, agree. We definitely don't want to encourage adding middleware to faraday or faraday_middleware anymore. I suggest we delete that completely or we explicitly say that we prefer new adapters/middleware to be added as separate gems.

Maybe we should think of some sort of review process and consequent addition to an official "middleware/adapters marketplace"? You know, to give these external projects some visibility

@olleolleolle
Copy link
Member Author

@iMacTia I changed some wording. This is an improvement, at least.

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iMacTia iMacTia merged commit 41c0dc7 into master May 7, 2020
@iMacTia iMacTia deleted the update-contributing branch May 7, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants