Drop git ls-files in gemspec

[utkarsh2102]

Hi @iMacTia,

Thanks for your work on this!

Whilst maintaining this in Debian, we found that this library relies on git to produce a list of files. Using git in gemspec files in problematic, in general.

It also adds the Packaging extension of RuboCop.
More about it can be found on https://docs.rubocop.org/rubocop-packaging/

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

[iMacTia]

Hi @utkarsh2102, thanks for taking care of faraday after doing the same for faraday_middleware.
I'd happily merge this change as well, but I noticed a require path was missed in the change.

[utkarsh2102]

Hi @iMacTia,

I'd happily merge this change as well, but I noticed a require path was missed in the change.

Thanks, I missed that, apologies. But has been fixed already! 😄
Also, I'd want to do the same set of changes for faraday-http, hope you'd be open for that as well?

[iMacTia]

Thanks @utkarsh2102 and sorry for the slow reply, I was travelling over the past days.
I'm still not 100% sure the current changes are compatible.
I'm particularly worried by comparing the old files list with the new one:

# OLD
files = %w[CHANGELOG.md LICENSE.md README.md Rakefile examples lib spec]

# NEW
files = Dir['CHANGELOG.md', '{examples,lib}/**/*', 'LICENSE.md', 'README.md']

I'm not sure the Rakefile and the spec folder are still included with the syntax change, but I may be wrong?

More than happy to have a similar PR for faraday-http as well ❤️ !

[olleolleolle]

Oh, I missed pressing "Submit Review". Dang.

[utkarsh2102]

Hi @iMacTia 👋🏻

Thanks @utkarsh2102 and sorry for the slow reply, I was travelling over the past days.

No problem at all! Thanks for all the reviews, you're still very fast and kind! 💫

I'm still not 100% sure the current changes are compatible.
I'm particularly worried by comparing the old files list with the new one:

# OLD
files = %w[CHANGELOG.md LICENSE.md README.md Rakefile examples lib spec]

# NEW
files = Dir['CHANGELOG.md', '{examples,lib}/**/*', 'LICENSE.md', 'README.md']

I'm not sure the Rakefile and the spec folder are still included with the syntax change, but I may be wrong?

No, you're absolutely right! I didn't quite understand the relevance of shipping spec/ and that of pec/external_adapters, but thanks to @olleolleolle, I do now! 😅

More than happy to have a similar PR for faraday-http as well heart !

Great, thank you so much, again! ❤️

[iMacTia]

Looks good now and all comments addressed 🎉 !
LGTM