Make dig method case-insensitive in Faraday::Utils::Headers #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
olleolleolle
reviewed
Apr 2, 2024
| it { expect(subject&.dig('Content-Type')).to eq('application/json') } | ||
| it { expect(subject&.dig('CONTENT-TYPE')).to eq('application/json') } | ||
| it { expect(subject&.dig(:content_type)).to eq('application/json') } | ||
| it { expect(subject&.dig('invalid')).to be_nil } |
There was a problem hiding this comment.
The safe-navigation operator is not needed here.
(The use of the subject dynamic definition's superfluous, too, but make no changes to that in this PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
#digmethod to Faraday::Utils::Headers to keep Hash access methods consistentFixes #1556
Todos
List any remaining work that needs to be done, i.e: