Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve response logger middleware output #784

Conversation

erichmachado
Copy link
Contributor

Description

Currently, log output looks like this with the firmware enabled:

get https://api.example.com
Status: 200

This PR changes the log output to be formatted like this instead:

 request: GET https://api.example.com
response: Status 200

Where the request and response strings are set as the progname of the INFO log calls accordingly, just like the debug lines currently work.

Fixes #782

@iMacTia iMacTia merged commit 6b564ee into lostisland:master Mar 26, 2018
@huangyq23
Copy link

This looks great! Do you plan to release a new gem version?

@iMacTia
Copy link
Member

iMacTia commented Apr 19, 2018

Yeah plan was to release tomorrow, but it may actually be easier today.
I'm creating the tag now, so expect to see the release later today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants