Add DEFAULT_EXCEPTIONS constant to Request::Retry #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krmannix
commented
Aug 22, 2018
lib/faraday/request/retry.rb
Outdated
| @@ -20,6 +20,7 @@ module Faraday | |||
| # | |||
| class Request::Retry < Faraday::Middleware | |||
|
|
|||
| DEFAULT_EXCEPTIONS = [Errno::ETIMEDOUT, 'Timeout::Error', Error::TimeoutError, Faraday::Error::RetriableResponse] | |||
There was a problem hiding this comment.
One potential addition is calling .freeze on this array, as exposing this list rather than constructing it on each call to exceptions means it's now modifiable by users. That may be okay though.
There was a problem hiding this comment.
Good point @krmannix.
However being this a constant, I would rather .freeze it and make it immutable as you suggested.
If we want to improve the way you simply add new exceptions to the list, we should probably revisit the API and provide a better way to do it.
No need to think about it now though, let's improve one bit at a time 😄
There was a problem hiding this comment.
great! I'll update. Thanks for the quick response!
iMacTia
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
DEFAULT_EXCEPTIONSconstant toRequest::Retry, which allows easy access much like theIDEMPOTENT_METHODSconstantTodos
None
Additional Notes
Initial request in Issue 813