Feature/#762 rspec #832
Merged
Feature/#762 rspec #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds bin folder with console and setup commands
started implementation of shared examples for adapters based on webmock rather than the live server
…land/patron#163) Hides skipped test form RSpec result
Converts parallel tests.
…ure/#762-rspec # Conflicts: # lib/faraday.rb # lib/faraday/connection.rb # test/adapters/logger_test.rb # test/parameters_test.rb
…ure/#762-rspec # Conflicts: # lib/faraday.rb
Moves Faraday::Utils classes (Headers and ParamsHash) into separate files. Converts Faraday::Utils::Headers tests.
Converts and isolates Faraday::Request and Faraday::Response tests.
Comments out unused function.
…ure/#762-rspec # Conflicts: # lib/faraday/utils.rb
…ure/#762-rspec # Conflicts: # lib/faraday/utils.rb
Fixes an issue with `rack_builder#dup`. Adds new `unregister_middleware` method to Faraday::Middleware.
…ure/#762-rspec # Conflicts: # test/adapters/net_http_persistent_test.rb
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts Minitests to RSpec 🎉
Fixes #762.
Todos
Additional Notes
With previous tests suite:
Time: 15s, Assertions: 1043With new tests suite:
Time: 12s, Examples: 1478Additionally, the previous tests suite needed to be executed twice, once with
SSL=falseand another withSSL=true. The new suite takes advantage of RSpec "shared examples" to test both scenarios in a single run. So in reality the runtime of the old suite was around 30s.