Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standalone adapters #941

Merged
merged 4 commits into from
Mar 10, 2019
Merged

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Mar 9, 2019

Description

This PR exposes a spec support file that external adapter gems can require in order to run all the relevant shared_examples to test an adapter.
You can see this tested (against this branch) here: lostisland/faraday-http#1

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR helps authors of external adapters a lot!

@olleolleolle olleolleolle merged commit 14b596f into master Mar 10, 2019
@iMacTia iMacTia deleted the support-standalone-adapters branch March 11, 2019 09:12
@technoweenie
Copy link
Member

Great work enabling Faraday to live its best life 🤘

@technoweenie technoweenie mentioned this pull request Jun 25, 2019
3 tasks
olleolleolle added a commit that referenced this pull request Feb 29, 2020
  - this was inadvertently removed in 0c873c1
  - the feature was introduced in #941
olleolleolle added a commit that referenced this pull request Mar 7, 2020
  - this was inadvertently removed in 0c873c1
  - the feature was introduced in #941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants