Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Navigation Fix #994

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Website Navigation Fix #994

merged 1 commit into from
Jul 8, 2019

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jul 8, 2019

Description

Fixes website navigation by adding trailing slashes to /index.md files.
See https://stackoverflow.com/questions/54727643/trailing-slashes-in-jekyll-github-pages-site-cause-404

Additional Notes

Tested locally and works (but it was working before the change as well.
Hard to say if it will work on GitHub Pages, but we can't really test before merging

@technoweenie
Copy link
Member

technoweenie commented Jul 8, 2019

That looks like it should fix the links in the top right have, from /faraday/{section} to /faraday/{section}/. That should work, unless GH Pages won't support a trailing slash in the URL like that. Considering that the site is only soft launched at an unused url, I think we can just ship this and cross our fingers.

EDIT: Did some more hunting, and this matches the docs/team.md:

https://github.com/lostisland/faraday/blame/master/docs/team.md#L4

Team___Faraday

@technoweenie technoweenie merged commit 8fa2b46 into master Jul 8, 2019
@technoweenie technoweenie deleted the fix/website-navigation branch July 8, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants