Configure Jekyll plugin jekyll-remote-theme to support Docker usage #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to build with Jekyll 3.6.x (`jekyll/jekyll:latest`). It went badly. By following the author guide https://github.com/benbalter/jekyll-remote-theme I noticed we were missing an entry. After this things work for me.
olleolleolle
approved these changes
Jul 9, 2019
|
Thank you @olleolleolle could you please check it does not break things for you locally? It seems from the linked article from the author https://github.com/benbalter/jekyll-remote-theme that things will be going this way, but I like to know I'm not missing a trick. |
Lewiscowles1986
changed the title
Lewiscowles1986
changed the title
|
@Lewiscowles1986 I tried it on my computer, by adding that line, and then running |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to build with Jekyll 3.6.x (
jekyll/jekyll:latest). It went badly.By following the author guide https://github.com/benbalter/jekyll-remote-theme I noticed we were missing an entry.
After this things work for me.
Todos
Additional Notes
I am using docker to build docs.