CI: Trust ruby/setup-ruby to install gems #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deal with "yard-junk now requires Ruby version >= 2.7.0. The current ruby version is 2.6.10.210."
iMacTia
reviewed
Sep 23, 2024
| - name: Set up Ruby 2.6 | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.6 | ||
| bundler-cache: true # 'bundle install' and cache gems |
There was a problem hiding this comment.
Oh this is very clever!
This way we don't need to guess the right bundler version, love it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the test CI setup to use as much knowledge as possible from the setup-ruby GH Action, keeping version number and such out of the file. For the yard-junk lint check, I did some steps.
Perhaps we can stop having the yard-junk check at all, we are not actively working on the docs of this project.