[skim v2] avoid panic when cache is disabled #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobWalt
added a commit
to RobWalt/fuzzy-matcher
that referenced
this pull request
Jun 29, 2024
The main problem with the old code was that all of the cache RefCells
were held for too long because of the huge scope of the `fuzzy`
function. The problem was already solved by just wrapping some of the
code with an extra scope `{` + `}`. However I chose to refactor a bit
and split the old function into 3 new ones:
- `simple_match` - was already there
- `sophisticated_match` - basically the else case of `simple_match`
- `fuzzy_inner` - a function just for the control flow of the other
function. This also handles the cache invalidation
This should supersede the pull request lotabout#20
|
I fixed this with another pull request. Nice find though and cool try to fix it through the github ui. Ngl that "lmao" made me chuckle quiet a bit. I like your energy :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i set
.use_cache(false)i got a panic:i think that's because
mis already an owned borrow (line 837), and same withchoice_charsandpattern_chars, all of which are still owned when we get to thisifdisclaimer: i didn't actually test this change (i did it in github's inline editor lmao). i can test later if desired