Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

little changes #36

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

little changes #36

wants to merge 4 commits into from

Conversation

Anekenonso
Copy link
Collaborator

connect issue below by replacing id with the number of your issue

connects #35

What does this PR do?

  • modified writeToTextFile function
  • modified readFromTextFile function

How can the implementation be tested

  • needs a little improvement

@Anekenonso Anekenonso added the enhancement New feature or request label Feb 20, 2019
@Anekenonso Anekenonso requested a review from louicoder February 20, 2019 20:17
@DrKimpatrick
Copy link
Collaborator

@Anekenonso Thanks for the good work but your branch has conflicts with develop. Please resolve them. Thanks

louicoder
louicoder reviewed Feb 25, 2019
View reviewed changes
Copy link
Owner

@louicoder louicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work. You have conflicts on your branch that you need to resolve. If you need help on that, please let me know so I can help

App/Files/FilesUtility/readAndWriteToFiles.js Outdated Show resolved Hide resolved
App/Files/FilesUtility/readAndWriteToFiles.js Outdated Show resolved Hide resolved
App/Files/FilesUtility/readAndWriteToFiles.js Outdated Show resolved Hide resolved
louicoder and others added 3 commits February 26, 2019 20:53
@louicoder @Anekenonso
Update App/Files/FilesUtility/readAndWriteToFiles.js
ddee829 
Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
@louicoder @Anekenonso
Update App/Files/FilesUtility/readAndWriteToFiles.js
41165d2 
Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
@louicoder @Anekenonso
Update App/Files/FilesUtility/readAndWriteToFiles.js
dfeb5fc 
Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louicoder louicoder louicoder left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anekenonso @DrKimpatrick @louicoder