Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following code:
This will currently raise an exception, complaining
"RED"
is not equal toColor.RED
. This is becauseLiteral
fields usemarshmallow.fields.Raw
, which does not reinterpret the string as an enum.This patch instead interprets the string as an enum if all literal values are of the same enum type, meaning the above code now works.
This is not a more general fix - for instance,
Literal[Color.RED, Animal.DOG]
will still not work. Fixing this is definitely possible, but would require a more complex solution and I wasn't sure it was worth it. Happy to implement it though if you'd prefer!