fix: ytbi thumbnail resolve

[lovegaoshi]

ytbi init (retrieve_player) must be true. i thought its not necessary bc it is caught by using ytm to resolve.

so ytm will now be used to resolve by default; and a new function separate from resolveURL to refresh metadata is added. for some reason ytm's metadata (really, cover) is not highres.

Summary by CodeRabbit

• New Features

  • Enhanced media URL resolution and metadata fetching capabilities.
  • Introduced robust error handling for metadata refresh operations.

• Bug Fixes

  • Improved control flow for URL resolution, potentially enhancing reliability.

• Refactor

  • Simplified initialization of the YouTube client, improving maintainability.
  • Streamlined the resolveURL function for better performance.

• Chores

  • Removed unnecessary asynchronous setup processes, simplifying component behavior.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 4:51pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes across multiple files, primarily focusing on the initialization and setup of the YouTube client and the handling of media URLs. Key modifications include the removal of asynchronous setup functions, alterations in error handling logic, and a shift towards a more static configuration of the YouTube client. These changes streamline the control flow and simplify the codebase, impacting how media fetching and player initialization are managed.

Changes

Files	Change Summary
src/hooks/useSetupPlayer.ts	Removed awaitYtbiSetup function call from useEffect, simplifying initialization logic.
src/utils/mediafetch/resolveURL.ts	Added fetchAudioInfo, renamed type alias from regResolve to RegResolve, introduced regexRefreshMetadata for metadata handling, and improved error handling.
src/utils/mediafetch/ytbSearch.ytbi.ts	Removed album property from the return object of ytbiVideoToNoxSong, altering data structure.
src/utils/mediafetch/ytbi.ts	Changed ytClient from a resettable Promise to a constant initialized directly, removed resetYtClient function, and simplified exports.
src/utils/mediafetch/ytbvideo.ts	Reversed the order of URL resolution attempts, prioritizing resolveURLMuse over resolveURLYtbi.
src/utils/mediafetch/ytbvideo.ytbi.ts	Simplified resolveURL function by removing the reset parameter and utilizing ytClientWeb directly.

Possibly related PRs

• fix: iOS ytbi #532: Changes in player setup logic relate to modifications in media fetching and client initialization.
• feat: ytbi playlist #543: Introduction of awaitYtbiSetup is relevant as it connects to the removal of this function in the current PR.
• feat: ytb live (streamed) #546: Changes to player setup logic in this PR are directly related to modifications in the same file.
• feat: ytbi migration #548: Updates to playlist and URL handling connect to alterations in player initialization and media fetching.

🐇 In the code's lush green glade,
Changes hop with a joyful parade.
The client now static, no longer a chase,
Media flows smoothly, a faster pace.
With regex and fetch, the tunes intertwine,
A rabbit's delight, in the code we shine! 🎶

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Error: [resolveURL] 362762021, qq-362762021 failed. fetchPlayUrlPromise(src/utils/mediafetch/resolv... View Issue

_{Did you find this useful? React with a 👍 or 👎}