Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yt suggest #611

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix: yt suggest #611

merged 4 commits into from
Oct 28, 2024

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Oct 28, 2024

closes #610

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced authentication and cookie management in the Explore component.
    • Added functions for suggesting related videos based on song data.
    • Introduced a new interface for improved type safety regarding login codes.
  • Bug Fixes

    • Streamlined the test suite by removing redundant tests and focusing on essential functionality.
  • Dependencies

    • Updated several package versions for improved compatibility and performance.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:26pm

@lovegaoshi lovegaoshi merged commit fd42a15 into master Oct 28, 2024
4 checks passed
Copy link

coderabbitai bot commented Oct 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant updates across several files, primarily focusing on the testing framework, module imports, and function definitions related to YouTube video handling. Key changes include the removal of obsolete tests, the addition of new functions for video suggestion, and updates to the authentication handling in the Explore component. Additionally, the Jest configuration has been adjusted to exclude a specific module, and various package dependencies have been updated to newer versions.

Changes

File Path Change Summary
__tests__/mediafetch/ytbvideo.test.ts Removed imports and tests; updated existing tests to focus on ytbi and muse functionalities.
jest.config.js Removed 'ytdl-core' from esModules array in Jest configuration.
package.json Updated versions of multiple dependencies in dependencies and devDependencies.
src/components/explore/ytmusic/View.tsx Added get_option import; updated authentication handling in onBackPress function.
src/components/login/google/useGoogleTVOauth.ts Introduced LoginCode interface for type safety in login codes.
src/hooks/useTPControls.ts Added ytbvideoFetch.regexResolveURLMatch2 to regexResolveURLs for enhanced URL resolution.
src/utils/mediafetch/ytbvideo.node.ts Deleted file containing functions for fetching YouTube video data.
src/utils/mediafetch/ytbvideo.ts Updated imports and changed suggest to suggestYtbi.
src/utils/mediafetch/ytbvideo.ytbi.ts Added suggestYTM and suggest functions for retrieving related videos.

Possibly related PRs

  • fix: iOS ytbi #532: Changes in src/utils/mediafetch/ytbvideo.ts regarding the resolveURL function's signature are directly related to this PR.
  • feat: ytbi playlist #543: Introduction of new functions in src/utils/mediafetch/ytbvideo.ytbi.ts, particularly the suggest function, aligns with the main PR.
  • feat: headless playback #566: Modifications in src/hooks/useTPControls.ts that enhance song suggestion logic are relevant to this PR.
  • feat: 让我们说中文 #584: Changes in localization files that introduce new entries for language settings relate to overall enhancements in user experience.

🐰 In the meadow where changes bloom,
New imports dance, dispelling gloom.
With tests refined and functions bright,
We hop along, all feels just right!
So let’s fetch songs and play our tune,
Under the sun, we'll sing 'til noon! 🌼🎶


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ytm mixlist shuffle does not work
1 participant