Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: billing #633

Merged
merged 3 commits into from
Nov 11, 2024
Merged

feat: billing #633

merged 3 commits into from
Nov 11, 2024

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Nov 11, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Added a new test case for the fetchInnerTuneSearch function to enhance testing coverage.
    • Integrated a new in-app billing permission to support purchases through the Google Play Store.
    • Improved UI with a new background color for playlist items to enhance visibility.
  • Bug Fixes

    • Adjusted the handling of icon colors for buttons in the playlist to improve visual consistency.
  • Refactor

    • Renamed the PlaylistList component to SongList for clarity in the codebase.
  • Chores

    • Updated various dependencies in the project to ensure compatibility and performance improvements.

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:08pm

@lovegaoshi lovegaoshi merged commit a8577e9 into master Nov 11, 2024
3 of 4 checks passed
Copy link

coderabbitai bot commented Nov 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on enhancing testing capabilities, modifying UI components, and updating dependencies. A new test case for the fetchInnerTuneSearch function is added, alongside updates to the AndroidManifest for billing permissions. The package.json file sees dependency updates and the addition of a new package. UI components undergo structural modifications, including the renaming of components and adjustments to styling properties for buttons and lists.

Changes

File Path Change Summary
__tests__/mediafetch/ytbsearch.test.ts Added a new test case museSearch for fetchInnerTuneSearch, importing it from ytbSearch.muse.
android/app/src/main/AndroidManifest.xml Added permission <uses-permission android:name="com.android.vending.BILLING" /> for in-app billing.
package.json Updated expo from ^52.0.0-preview.23 to ^52.0.2, expo-image from ~2.0.0-preview.1 to ~2.0.0, added react-native-purchases ^8.2.6, and updated uuid from ^11.0.2 to ^11.0.3.
src/components/player/View.tsx Added an outer <View> component wrapping <SafeAreaView>, maintaining existing structure.
src/components/playlist/Menu/PlaylistMenuButton.tsx Removed useNoxSetting import; commented out dynamic iconColor assignment for IconButton.
src/components/playlist/SongList/SongList.tsx Commented out iconColor for "select-all", "select", and "magnify" icons, affecting their visual representation.
src/components/playlist/View.tsx Renamed imported component from PlaylistList to SongList, updating JSX rendering accordingly.
src/components/playlists/Playlists.tsx Changed background color assignment for TouchableRipple and integrated NewPlaylistDialog with new state variable.

Possibly related PRs

  • feat: ytbi playlist #543: Updates to test cases for the ytbplaylist functionality, related to the new test case for fetchInnerTuneSearch.
  • feat: headless playback #566: Modifications to the useSetupPlayer file, potentially connecting to enhancements in player functionality.
  • feat: 让我们说中文 #584: Implementation of Chinese language support, which may affect the localization aspects of the fetchInnerTuneSearch function.
  • fix: new arch #631: Enhancements in error handling and logic for MusicService, related to media handling improvements.

🐇 In a world of code and tests so bright,
We added a search to fetch with delight.
With buttons refined and colors anew,
Our app's ready for users, both old and new!
Let’s hop through the changes, with joy we proclaim,
In the land of the code, we’re winning the game! 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning expo > @expo/cli > @expo/plist > @xmldom/xmldom@0.7.13: this version is no longer supported, please update to at least 0.8.*
warning expo > @expo/cli > @react-native/dev-middleware > chromium-edge-launcher > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning expo > @expo/cli > @expo/package-manager > npm-package-arg > osenv@0.1.5: This package is no longer supported.
warning expo > @expo/cli > tempy > del > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > jscodeshift > temp > rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > jscodeshift > temp > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > jscodeshift > @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > jscodeshift > @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
warning expo > babel-preset-expo > @react-native/babel-preset > @react-native/babel-plugin-codegen > @react-native/codegen > jscodeshift > @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
error Couldn't find any versions for "react-native" that matches "patch:react-native@npm%3A0.76.1#~/.yarn/patches/react-native-npm-0.76.1-c738a2fa39.patch"


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant