fix: motionlayout perf

[lovegaoshi]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced drag-and-drop functionality for playlist items using FlashDragList.
  • Improved visual feedback during drag operations with scaling effects.

• Bug Fixes

  • Adjusted artwork display dimensions for better alignment in the miniplayer.

• Documentation

  • Updated localization strings for clarity and tone in both English and Chinese.

• Chores

  • Removed unused imports and streamlined code for improved maintainability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 17, 2024 11:27pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves significant changes primarily centered around the package.json file for the azusa-player-mobile project, where the dependency react-native-draggable-flatlist has been removed and replaced with react-native-flashdrag-list. This change is accompanied by various updates across multiple components, including enhancements to the drag-and-drop functionality, modifications to artwork display properties, and updates to localization files. Additionally, new constants have been introduced for revenue management, and some constants have been adjusted to reflect changes in the application's configuration.

Changes

File	Change Summary
package.json	Removed dependency react-native-draggable-flatlist and added react-native-flashdrag-list.
patches/react-native-flashdrag-list+0.2.4.patch	Enhanced FlashDragList with new shared values and improved drag-and-drop animations.
src/@types/dotenv.d.ts	Added constants REVENUECAT_STRIPE and REVENUECAT_GOOGLE.
src/components/miniplayer/Artwork.tsx	Adjusted calculations for artwork dimensions and removed allowDownscaling property.
src/components/miniplayer/Constants.ts	Updated MinPlayerHeight constant from 75 to 65.
src/components/miniplayer/MiniControls.tsx	Modified logic for miniControlOpacity calculation.
src/components/miniplayer/ProgressBar.tsx	Changed translateY styling from -15 to -10.
src/components/miniplayer/View.tsx	Removed paddingTop: 5 style from the player controls.
src/components/playlists/PlaylistItem.tsx	Updated syntax for View component to use a self-closing tag.
src/components/playlists/Playlists.tsx	Replaced DraggableFlatList with FlashDragList and modified renderItem function signature.
src/components/playlists/View.tsx	Updated props type from any to DrawerContentComponentProps.
src/components/setting/helpers/SelectSetting.tsx	Removed unused import of SettingEntry.
src/hooks/useVIP.ts	Added revenueCatAPI function and updated init function to use dynamic API key selection.
src/localization/en/translation.json	Updated artworkResDesc key description in English localization.
src/localization/zhcn/translation.json	Modified various strings, including artworkResDesc in Chinese localization.
src/objects/Storage.ts	Changed artworkRes property from 720 to 0 in DefaultSetting.

Possibly related PRs

• chore: RN 0.75 #533: The changes in this PR involve replacing DraggableFlatList with FlashDragList, which is directly related to the dependency change in the main PR where react-native-draggable-flatlist was replaced with react-native-flashdrag-list.
• feat: ytb live (streamed) #546: This PR updates the package.json file, which is relevant as it includes version updates for dependencies, similar to the changes made in the main PR.
• feat: headless playback #566: This PR also modifies the package.json file, updating dependencies and scripts, which aligns with the dependency management aspect of the main PR.
• feat: 让我们说中文 #584: This PR includes updates to localization files, which may relate to the overall project structure and dependencies, although it is less directly connected to the main PR's focus on dependency changes.
• fix: new arch #631: This PR focuses on enhancing error handling and modifying logic in the APMWidget.kt file, which may not be directly related to the main PR but indicates ongoing improvements in the project.
• fix: ghactions oos #640: This PR addresses GitHub Actions workflow issues, which may not be directly related to the main PR's changes in package.json, but reflects ongoing maintenance efforts in the project.

🐇 In the meadow, we hop and play,
With lists that drag and items that sway.
New colors bright, and heights that shrink,
Our code is clean, and we all can think!
With every change, we dance with glee,
For a better app, just wait and see! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud