fix: useActiveTrack

[lovegaoshi]

properly implement activeTrack as a global store

Summary by CodeRabbit

Release Notes

• New Features

  • Transitioned to a centralized state management approach for track data across multiple components.

• Bug Fixes

  • None reported.

• Documentation

  • Updated comments and documentation to reflect changes in state management.

• Refactor

  • Replaced useActiveTrack with useTrackStore in various components for improved state handling.

• Chores

  • Removed outdated methods related to track updates from the state management interface.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 8:21pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve a refactoring of how the active track is accessed across multiple components within the application. The previous method of using the useActiveTrack hook has been replaced with a new state management approach utilizing useTrackStore. This transition affects various components including Artwork.tsx, Lrc.tsx, MiniControls.tsx, TrackInfo.tsx, and others, ensuring that they now retrieve track information directly from the centralized store. The overall structure and functionality of the components remain unchanged.

Changes

File Path	Change Summary
src/components/miniplayer/Artwork.tsx	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/components/miniplayer/Lrc.tsx	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/components/miniplayer/MiniControls.tsx	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/components/miniplayer/TrackInfo.tsx	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/components/player/TrackInfo/SongMenu.tsx	Changed updateTrack access from useNoxSetting to useTrackStore.
src/components/player/controls/ThumbsUpButton.tsx	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/components/player/controls/usePlayerControls.ts	Updated track and updateTrack access from useActiveTrack and useNoxSetting to useTrackStore.
src/hooks/useAccentColor.ts	Updated import from useActiveTrack to useTrackStore. Changed track access method to use store directly.
src/hooks/useActiveTrack.ts	Introduced Zustand store for track management, defining TrackStore interface and methods for track handling.
src/hooks/useSetupPlayer.ts	Added import for useActiveTrack but marked as unused.
src/stores/useApp.ts	Removed updateTrack and setUpdateTrack methods from NoxSetting interface.

Possibly related PRs

• feat: ytbi playlist #543: The changes in this PR involve modifying the way the current track is accessed in multiple components, similar to the main PR's focus on changing the method of accessing the active track in the Artwork.tsx component.
• feat: ytb live (streamed) #546: This PR also modifies the way the current track is accessed, aligning with the main PR's changes in state management for track information.

🐰 In the land of tracks, a change was made,
From hooks to stores, a new path laid.
Components now dance with data so bright,
In harmony they play, from morning till night.
With each little hop, our code finds its way,
A symphony of tracks, come join the ballet! 🎶✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud