fix: nox import

[lovegaoshi]

closes lovegaoshi/NoxPlayer#102

Summary by CodeRabbit

• New Features

  • Introduced new vector drawables for play and shuffle icons, enhancing the app's visual elements.
  • Added adaptive icons for play and shuffle functionalities, improving the app's appearance on various device configurations.
  • Implemented a new splash screen component that displays random images or videos during app launch.

• Bug Fixes

  • Updated shortcut icons for existing functionalities to ensure consistency and improved user experience.

• Chores

  • Refined state management and props handling in various components for better performance and maintainability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 0:47am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several new vector drawable resources and adaptive icons for the Android application, enhancing the visual elements associated with media controls. Additionally, it modifies existing components to improve flexibility and state management, particularly in splash screens and dialog handling. Key changes include the addition of new splash screen components, updates to icon resources in the shortcuts configuration, and enhancements to the handling of selection dialogs within the settings.

Changes

File Path	Change Summary
android/app/src/main/res/drawable/shortcut_play_background.xml	New vector drawable defining a grid-like pattern background.
android/app/src/main/res/drawable/shortcut_play_foreground.xml	New vector drawable for a play icon.
android/app/src/main/res/drawable/shortcut_shuffle_on_background.xml	New vector drawable defining a grid-like pattern background.
android/app/src/main/res/drawable/shortcut_shuffle_on_foreground.xml	New vector drawable for a shuffle icon.
android/app/src/main/res/mipmap-anydpi-v26/shortcut_play.xml	New adaptive icon referencing the play background and foreground drawables.
android/app/src/main/res/mipmap-anydpi-v26/shortcut_play_round.xml	New adaptive icon for round displays, referencing the same drawables.
android/app/src/main/res/mipmap-anydpi-v26/shortcut_shuffle_on.xml	New adaptive icon referencing the shuffle background and foreground drawables.
android/app/src/main/res/mipmap-anydpi-v26/shortcut_shuffle_on_round.xml	New adaptive icon for round displays, referencing the shuffle drawables.
android/app/src/main/res/values/shortcut_play_background.xml	New color resource for play background.
android/app/src/main/res/values/shortcut_shuffle_on_background.xml	New color resource for shuffle background.
android/app/src/main/res/xml/shortcuts.xml	Updated icon resources for existing shortcuts.
src/components/background/AppOpenSplash.tsx	New component for managing splash screens with various content types.
src/components/dialogs/GenericSelectDialog.tsx	Modified options prop to be optional and initialized to an empty array.
src/components/explore/YTMusic.tsx	Updated import statement for React.
src/components/landscape/LandscapePlayerPanel.tsx	Added import statement for React.
src/components/login/google/YTM.tsx	Updated import statement for React.
src/components/miniplayer/Lrc.tsx	Updated import statement for useCallback from React.
src/components/player/controls/WavyAnimation.tsx	New functional component for animated wave graphics.
src/components/setting/DeveloperSettings.tsx	Enhanced Home component structure and functionality.
src/components/setting/SelectDialogWrapper.tsx	New generic dialog wrapper component for managing selection dialogs.
src/components/setting/SyncSettings.tsx	Modified onSubmit handler for GenericCheckDialog.
src/components/setting/appearances/SelectDarkModeButton.tsx	Replaced GenericSelectDialog with SelectDialogWrapper.
src/components/setting/helpers/SelectSetting.tsx	Updated type for setCurrentSelectOption to allow undefined.
src/components/setting/helpers/SettingEntry.ts	Removed dummySelectSettingEntry constant.
src/components/setting/sync/useSync.ts	Enhanced data structure in syncPartialNoxExtension function and refined error handling.
src/localization/i18n.ts	Updated compatibilityJSON property from 'v3' to 'v4'.
src/utils/ChromeStorage.ts	Updated playlist handling in clearPlaylistNImport and addImportedPlaylist functions.

Assessment against linked issues

Objective	Addressed	Explanation
Address the issue of playlist sync (102)	✅

🐰 In the meadow, where changes bloom,
New icons and splashes dispel the gloom.
With colors bright and patterns bold,
Our app's new look is a sight to behold!
Hopping along, we celebrate this feat,
In every click, our joy is complete! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud