Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ytm login #674

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: ytm login #674

merged 2 commits into from
Dec 4, 2024

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Dec 4, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced user authentication process with improved cookie management.
    • Introduced a new method for extracting cookie values to streamline authentication.
  • Bug Fixes

    • Adjusted cookie parsing logic for better accuracy in handling user sessions.
  • Refactor

    • Streamlined control flow in user session management and initialization processes.
  • Documentation

    • Updated method names to reflect changes in functionality and improve clarity.

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 6:24pm

@lovegaoshi lovegaoshi merged commit a572c61 into master Dec 4, 2024
5 of 6 checks passed
Copy link

coderabbitai bot commented Dec 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve significant updates to the user authentication and cookie management logic across several files. The YTM.tsx file now initializes the muse store before checking the current user and modifies cookie parsing. The initializeStores.ts file reflects a renaming of the initializeMuse function to initMuse. In muse.ts, the MemoryStore class has been removed, and the module has shifted to a cookie-based authentication approach, introducing new functions for cookie handling and header generation.

Changes

File Path Change Summary
src/components/login/google/YTM.tsx Updated import statements; simplified clearCookies; modified checkYTM and onMessage functions; adjusted logout process.
src/stores/initializeStores.ts Renamed initializeMuse to initMuse in import and function call.
src/utils/muse.ts Removed MemoryStore class; renamed initialize to initMuse; added findCookie and get_headers functions; shifted to cookie-based authentication.

Poem

In the land of code where bunnies play,
Changes hop in a bright array.
Cookies now dance, authentication's new,
With initMuse guiding us through.
So let's celebrate, with joy and cheer,
A streamlined path for all to steer! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9806a8a and 7bb6860.

📒 Files selected for processing (3)
  • src/components/login/google/YTM.tsx (3 hunks)
  • src/stores/initializeStores.ts (2 hunks)
  • src/utils/muse.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Dec 4, 2024

@lovegaoshi lovegaoshi mentioned this pull request Dec 4, 2024
Copy link

sentry-io bot commented Dec 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read property 'split' of null findCookie(src/utils/muse) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant