fix: newarch drawer height

[lovegaoshi]

Summary by CodeRabbit

• New Features

  • Enhanced mini player functionality with improved height adjustments based on window dimensions.
  • Introduced state management for mini player shrink status, affecting layout behavior in playlists.

• Bug Fixes

  • Adjusted layout conditions to ensure proper height settings based on mini player state.

• Chores

  • Improved code clarity by changing variable declarations from let to const for better immutability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 12, 2024 2:49am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications to the miniplayer and playlist components within the application. Key changes include the addition of state management for the miniplayer's size and visibility, utilizing the useNoxSetting hook to track the MiniPlayerShrunk state. The initialization of miniplayerHeight has been updated to reflect the current window height. Additionally, the playlist component's layout behavior is adjusted based on the new miniPlayerShrunked state. The APMUI store is updated to include properties and methods for managing the miniplayer's state, enhancing overall responsiveness and layout handling.

Changes

File Path	Change Summary
src/components/miniplayer/View.tsx	- Added const miniplayerShrunk = useNoxSetting(state => state.MiniPlayerShrunk);
	- Updated const miniplayerHeight = useSharedValue(height); from MinPlayerHeight initialization.
	- Modified collapse function to invoke runOnJS(miniplayerShrunk)() after setting height.
	- Removed useEffect for setting miniplayerHeight after timeout.
src/components/playlists/View.tsx	- Added const miniPlayerShrunked = useNoxSetting(state => state.miniPlayerShrunked);
	- Updated layout height setting logic to check miniPlayerShrunked.
src/stores/useAPMUI.ts	- Added miniPlayerShrunked: boolean to APMUIStore interface.
	- Added method MiniPlayerShrunk: () => void to APMUIStore.
	- Initialized miniPlayerShrunked: false in store state.
	- Implemented MiniPlayerShrunk: () => set({ miniPlayerShrunked: true }).
src/stores/usePlaylists.ts	- Changed variable declarations from let to const for several methods.
	- Modified setCurrentPlayingId to include getABRepeatRaw(val).
	- Ensured setCurrentPlayingList updates only if the new list differs.

Possibly related PRs

• feat: no repeat #547: Introduces a new state variable miniPlayerShrunked related to the MiniPlayerShrunk state management.
• feat: headless playback #566: Modifications to player setup and initialization logic, potentially related to miniplayer state management.
• fix: ghactions oos #640: Focuses on GitHub Actions, with no direct connection to the miniplayer changes.
• feat: lint check on PR #668: Introduces a linting workflow, unrelated to the functional changes in the miniplayer component.

🐰 In the meadow where bunnies play,
The miniplayer's here to stay!
With heights that dance and states that shrink,
Our code now flows without a blink.
Hopping high, we cheer with glee,
For changes made, oh joy, oh me! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 144a622 and 44b8c5d.

📒 Files selected for processing (4)

• src/components/miniplayer/View.tsx (2 hunks)
• src/components/playlists/View.tsx (2 hunks)
• src/stores/useAPMUI.ts (2 hunks)
• src/stores/usePlaylists.ts (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud