-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve performance of getReport()
#21
fix: improve performance of getReport()
#21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR Steven, I hadn't seen this new feature. Is it just me or is the API we have to use to set excludeNetwork
somewhat awkward?
I've made a suggestion to move the /* istanbul ignore next */
exclusion up a level to the surrounding conditional, which I think should deal with the unit test failure.
I need to fix up the integration tests first as NodeSource have totally changed the way their repos work, plus a couple of the more rolling flavours of Linux such as Fedora 39 have upgraded their version of glibc within the last few months. Leave it with me.
UPDATE: Please can you rebase against main
and the integration tests should pass again.
Agreed. Its not just |
Co-authored-by: Lovell Fuller <lovell@users.noreply.github.com>
fc742e5
to
48e937c
Compare
I'm also wondering if we should update CI to run against Node.js Nightly just to confirm this doesn't cause any problems (since this feature hasn't landed on the stable channel yet) https://nodejs.org/download/nightly/v22.0.0-nightly20240304b34512e38e/ |
Thanks for the updates. Let's wait until there's a proper, non-nightly (backported?) release of Node.js with the new flag before merging/releasing. |
I'm going to merge this now as the change in #22 means the use of There are no nightly Node.js builds for musl and the upstream |
Thanks again for the PR, this change was included in v2.0.3. |
This will speed up the report generation and avoid unwanted DNS queries during the report See lovell/detect-libc#21
This will improve performance for newer versions of Node.js because this report doesn't need to access the network.
--report-exclude-network
option nodejs/node#51645