Disable debug mode in hash functions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I need to update the CI environment as CentOS 7 is EOL, leave it with me. |
|
Please can you rebase against upstream/main to pick up the CI fixes. |
a last step of the hash functions runs one more swap if activated debug mode. this debug flags makes slow down the processing speed and it also always makes different result as fingerprint. close lovell#51
d3m3vilurr
force-pushed
the
disable-debug-mode
branch
from
98a1502
to
33b51fc
Compare
|
@lovell can you recheck this PR? I rebased it yesterday. |
|
Thank you, looks good, this will be semver major as this affects the public API. As an aside, given the major version bump will also be dropping support for Node.js 10, I can now switch to |
|
v4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a last step of the hash functions runs one more swap if activated debug mode.
this debug flags makes slow down the processing speed and it also always makes different result as fingerprint.
close #51