Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding issue when reading a huge amount of rows with a lot of data in each one #75

Merged

Conversation

lovetodream
Copy link
Owner

No description provided.

@lovetodream lovetodream added the semver-patch No public API change. label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 83.44371% with 25 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (6d72308) to head (e373a8b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...O/Messages/OracleBackendMessage+BackendError.swift 76.59% 11 Missing ⚠️
...rces/OracleNIO/Messages/OracleBackendMessage.swift 54.16% 11 Missing ⚠️
...O/Messages/Coding/OraclePartialDecodingError.swift 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   88.00%   88.01%           
=======================================
  Files         149      150    +1     
  Lines       21125    21197   +72     
=======================================
+ Hits        18592    18657   +65     
- Misses       2533     2540    +7     
Files with missing lines Coverage Δ
...cleNIO/Extensions/ByteBuffer/ByteBuffer+OSON.swift 93.33% <100.00%> (+3.33%) ⬆️
...yteBuffer/ByteBuffer+ThrowingMoveReaderIndex.swift 100.00% <100.00%> (ø)
...racleNIO/Extensions/ByteBuffer/ByteBuffer+UB.swift 92.89% <100.00%> (+0.97%) ⬆️
...cleNIO/Messages/OracleBackendMessage+RowData.swift 96.26% <100.00%> (ø)
...NIOTests/Extensions/ByteBufferExtensionTests.swift 100.00% <100.00%> (ø)
Tests/OracleNIOTests/Messages/ControlTests.swift 100.00% <100.00%> (ø)
...O/Messages/Coding/OraclePartialDecodingError.swift 43.90% <40.00%> (-0.55%) ⬇️
...O/Messages/OracleBackendMessage+BackendError.swift 80.83% <76.59%> (+2.43%) ⬆️
...rces/OracleNIO/Messages/OracleBackendMessage.swift 67.69% <54.16%> (-3.03%) ⬇️

... and 2 files with indirect coverage changes

@lovetodream lovetodream merged commit e9f8439 into main Nov 13, 2024
5 of 7 checks passed
@lovetodream lovetodream deleted the fix-bug-when-reading-huge-amounts-of-row-with-a-lot-of-data branch November 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant