Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups in get_fcov.py #2074

Closed
wants to merge 1 commit into from

Conversation

rswarbrick
Copy link
Contributor

Avoid importing some stuff that we're not using. Break a long line. No functional change.

Avoid importing some stuff that we're not using. Break a long line. No
functional change.
@rswarbrick rswarbrick added Type:Cleanup Cleanup tasks Component:DV Design verification (DV) or testing issue labels Aug 15, 2023
@rswarbrick
Copy link
Contributor Author

Hmm, I think @hcallahan-lowrisc remembers that these were actually needed for some library to work properly. We should probably fix things or at least add a documentation comment, but I'm not exactly sure what was going on! So I'm closing this for now: we can always tidy it up later.

@rswarbrick rswarbrick closed this Aug 15, 2023
@rswarbrick rswarbrick deleted the get-fcov-cleanup branch August 15, 2023 11:18
@hcallahan-lowrisc
Copy link
Contributor

I just tried this now to see if I remembered it right. If you remove the import, you get the following traceback:
(I removed it in compile_tb.py, but the outcome would be the same)

  File "dv/uvm/core_ibex/scripts/compile_tb.py", line 110, in <module>
    sys.exit(_main())
  File "dv/uvm/core_ibex/scripts/compile_tb.py", line 51, in _main
    with LockedMetadata(args.dir_metadata, __file__) as md:
  File "dv/uvm/core_ibex/scripts/metadata.py", line 496, in __enter__
    self.md = pickle.load(self.handle)
AttributeError: Can't get attribute 'RegressionMetadata' on <module '__main__' from 'dv/uvm/core_ibex/scripts/compile_tb.py'>

This seems to be something strange to do with re-loading the pickled file. At a glance, I'm out of ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV Design verification (DV) or testing issue Type:Cleanup Cleanup tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants