Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix background in block diagram #2078

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

marnovandermaas
Copy link
Contributor

@marnovandermaas marnovandermaas commented Aug 25, 2023

The background was originally a gradient background on the right together with a solid background on the left. This caused some distortion on closer inspection. This commit changes it to have one background that is a gradient from left to right.

The background of the Icache block was a not-well-fitted path that was causing the background to seep through. This commit updates that background to more tightly align with the lines and letters.

The background was originally a gradient background on the right
together with a solid background on the left. This caused some
distortion on closer inspection. This commit changes it to have one
background that is a gradient from left to right.
@marnovandermaas
Copy link
Contributor Author

You can see that the original background is not correct when viewing it on a dark background:
image

The background of the Icache block was a not-well-fitted path that was
causing the background to seep through. This commit updates that
background to more tightly align with the lines and letters.
Copy link
Contributor

@hcallahan-lowrisc hcallahan-lowrisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marnovandermaas marnovandermaas added this pull request to the merge queue Aug 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 28, 2023
@nbdd0121 nbdd0121 added this pull request to the merge queue Aug 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2023
@marnovandermaas marnovandermaas added this pull request to the merge queue Aug 30, 2023
Merged via the queue into lowRISC:master with commit db6257b Aug 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants