Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK3 #113

Closed
wants to merge 18 commits into from
Closed

GTK3 #113

wants to merge 18 commits into from

Conversation

bp0
Copy link
Collaborator

@bp0 bp0 commented Jul 25, 2017

v2: #114.

Currently, this is the same as #59, but rebased with conflicts resolved. I'll push my changes here.
TODO at #112.

So far:

  • Added cmake option for gtk3
  • hardinfo/util.c should be working, but deprecation warnings remain for gtk_ui_manager_remove_ui() and GtkStock.
  • shell/report.c should be working but a deprecation warning remains for gtk_dialog_get_action_area().
  • builds and runs, but has bugs (see GTK3 TODO #112 (comment))
  • loadgraph doesn't work

Note: "test555" is @TotalCaesar659. That's how it appears in the commit at #59. Perhaps if ever this gets merged, pause after that commit and commit --amend --author="TotalCaesar659 <x24cm5b8c54q6szxw@yandex.ru>" to correct the author.

@bp0 bp0 mentioned this pull request Jul 25, 2017
bp0 added 16 commits July 24, 2017 22:31
* widget_set_cursor() gtk3 changes
* For now, the whole function tree_view_save_image() is disabled
  for gtk3.

Signed-off-by: Burt P <pburt0@gmail.com>
Disable RANGE_GET_VALUE() RANGE_SET_VALUE() macros for GTK3. This
is a nigtmare onion to try and peel.

Signed-off-by: Burt P <pburt0@gmail.com>
Diff is noisy because of removed trailing whitespace.

Signed-off-by: Burt P <pburt0@gmail.com>
gtk_about_dialog_set_name() -> gtk_about_dialog_set_program_name()
after GTK+2.12.

Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Builds, but doesn't yet function in gtk3.

Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Not working, but also not crashing, and not emitting runtime warnings.

Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
Signed-off-by: Burt P <pburt0@gmail.com>
@mckaygerhard
Copy link
Contributor

hi @bp0 try to avoid publicite tips about emails and aliases.. iu thing (based ont their profile) totalcaesar want to mantain private ...

@bp0
Copy link
Collaborator Author

bp0 commented Jul 25, 2017

The author line I've used is from all of his other public commits.
"Author: Your Name test@mail.com" is clearly just unconfigured git or similar.

@bp0 bp0 mentioned this pull request Jul 25, 2017
@bp0
Copy link
Collaborator Author

bp0 commented Jul 25, 2017

Closing. Check out PR #114.

@bp0 bp0 closed this Jul 25, 2017
@bp0 bp0 deleted the gtk3 branch August 3, 2017 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants