Repositiory now implements Doctrine\Common\Persistence\ObjectRepository #79
Conversation
| */ | ||
| public function findBy(array $criteria) | ||
| public function findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null) |
There was a problem hiding this comment.
Exception if I use a common API method?
|
@Deltachaos I'm currently managing to implement the Doctrine Common interfaces (especially ObjectManager and ObjectRepository) correctly. This is definitively a need, but I don't see the benefit of implementing interfaces and throwing exceptions if they are used as originally intended by Doctrine Common. |
|
If it can be supported, we should support the arguments, not just accept them to respect the interface. That would be breaking the contract. If the argument cannot be implemented for technical reasons, then I agree on an exception to avoid false promises. |
|
@lphuberdeau Working on a solution based on #74 which also implements the ObjectManager interface. Will propose, once it's final ;) BTW. Thx 4 merge... |
Because all Repositiories should implement this interface