Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercises: Fix quiz statistics footer overlap with general footer #8925

Merged

Conversation

asliayk
Copy link
Contributor

@asliayk asliayk commented Jun 30, 2024

Checklist

General

Client

Motivation and Context

The quiz statistics footer is hidden by the general footer. Both footers should be displayed.
Closes #8890

Description

Both footers are now visible, and the quiz footer appears above the general footer.

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Log in to Artemis
  2. Navigate to course management page, select a course that has at least one quiz exercise, and click on Exercises button
  3. Select a quiz exercise and go to the statistics of it
  4. See that both footers are visible, the quiz footer appears above the general footer

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

OLD
image

NEW
image

Summary by CodeRabbit

  • Style
    • Adjusted the positioning of the quiz statistics footer to improve layout by changing the bottom margin from 0 to 4vh.

@asliayk asliayk added client Pull requests that update TypeScript code. (Added Automatically!) small bugfix user interface labels Jun 30, 2024
@asliayk asliayk self-assigned this Jun 30, 2024
@asliayk asliayk requested a review from a team as a code owner June 30, 2024 20:21
Copy link

coderabbitai bot commented Jun 30, 2024

Walkthrough

The change in the quiz-statistics-footer.component.scss file adjusts the positioning of the .quiz-statistic-footer class by changing the bottom property from 0 to 4vh. This modification ensures that the quiz statistics footer is no longer hidden behind the general footer, addressing the visibility issue described in the linked issue.

Changes

File Change Summary
src/.../quiz-statistics-footer/quiz-statistics-footer.component.scss Adjusted .quiz-statistic-footer bottom property from 0 to 4vh to ensure visibility of the footer.

Assessment against linked issues

Objective Addressed Explanation
The quiz statistics footer should be displayed at the bottom and not hidden by the general footer (#8890)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@krusche krusche changed the title Quiz Exercises: Fix quiz statistics footer overlap with general footer Quiz exercises: Fix quiz statistics footer overlap with general footer Jul 5, 2024
@krusche krusche added this to the 7.4.1 milestone Jul 5, 2024
@krusche krusche merged commit d9aa184 into develop Jul 5, 2024
31 of 35 checks passed
@krusche krusche deleted the feature/quiz-exercises/footer-hiding-quiz-statistics-footer branch July 5, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) component:Quiz ready for review small user interface
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Quiz exercises: Footer hiding quiz statistics footer
3 participants