-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Reduce width of sidebar
#9171
Conversation
WalkthroughThe recent updates to the sidebar component focus on enhancing the user interface through refined padding and width adjustments. By reducing the sizes of both open and closed sidebar states and improving transition effects, the design aims to create a more user-friendly experience. These modifications enhance visual hierarchy and accessibility, allowing for smoother interactions and improved aesthetics. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Sidebar
participant Content
User->>Sidebar: Click to expand/collapse
Sidebar->>Sidebar: Adjust width and padding
Sidebar->>Content: Update layout
Content->>User: Show updated sidebar
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and Screenshots look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts5, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Tested on TS5. Extra padding and background in sidebar is removed as described. However, I found the following minor issues:
- if we have more than 10 questions in an exam, overview icon can not be seen fully. Besides, is it intended to place the collapse icon on the right when the sidebar is collapsed? (See screenshot 1)
- If we shrink the window to the left, there is a horizontal and vertical scrollbar. Vertical scrollbar also blocks the status icons of questions. I think we also need to remove the horizontal scrollbar and display question and status icon next to each other in this edge case. (See screen record)
Screen.Recording.2024-08-05.at.17.04.39.mov
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
357ec71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this PR. I have a small remark regarding the tooltip renaming.
...n/webapp/app/exam/participate/exam-navigation-sidebar/exam-navigation-sidebar.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍
Checklist
General
Client
Motivation and Context
We aim to provide students with more horizontal space, particularly when they use split-screen during an exam.
Description
This PR removes the padding and the extra background of the sidebar.
Exam Mode Testing
(There is already an exam on TS5 called 'Reduce Sidebar Width 2' and test users 1-5 are registered to the exam.)
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Screenshots
Sidebar open before
Sidebar open after
Sidebar collapsed before
Sidebar collapsed after
Summary by CodeRabbit
New Features
Bug Fixes
Style