Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communication: Fix content overflow in expanded thread view #9474

Merged
merged 8 commits into from
Oct 27, 2024
Merged

Communication: Fix content overflow in expanded thread view #9474

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb4f73d
fix card width for thread view
asliayk Oct 13, 2024
38e7597
Merge branch 'develop' into bugfix/communication/fix-expand-thread-view
asliayk Oct 18, 2024
86af4fe
Merge branch 'develop' into bugfix/communication/fix-expand-thread-view
asliayk Oct 19, 2024
2714f53
Merge branch 'develop' into bugfix/communication/fix-expand-thread-view
asliayk Oct 26, 2024
801c1c9
refactor styling
asliayk Oct 26, 2024
1107caf
Merge branch 'develop' into bugfix/communication/fix-expand-thread-view
asliayk Oct 26, 2024
89f2587
refactor styling
asliayk Oct 27, 2024
f44ef63
added test
asliayk Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...nversations/layout/conversation-thread-sidebar/conversation-thread-sidebar.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

$draggable-width: 15px;
$thread-section-card-min-width: 420px;
$thread-section-card-max-width: 540px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Potential Conflicts Detected.
Several hardcoded widths and media queries were found that may conflict with the new $thread-section-card-max-width. Please review these instances to ensure consistent and conflict-free styling across the codebase.

  • Hardcoded Widths:

    • width: 38px; in conversation-thread-sidebar.component.scss
    • Other instances in related .scss files

  • Media Queries:

    • @media (max-width: 768px) in multiple components
    • @media screen and (max-width: 992px) in conversation-thread-sidebar.component.scss
🔗 Analysis chain

Summary: Changes look good. Consider verifying across different screen sizes.

The implementation of $thread-section-card-max-width and its application to the .card element should effectively address the content overflow issue in the expanded thread view. The changes are minimal and focused, maintaining the existing responsive design.

To ensure the effectiveness of these changes:

Please run the following script to check if there are any potential conflicts with the new max-width in other parts of the codebase:

Additionally, it would be beneficial to manually test the changes across various screen sizes to ensure the layout remains consistent and functional.

Also applies to: 41-41

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for potential conflicts with the new max-width

# Test 1: Search for other occurrences of max-width in related files
echo "Searching for other max-width occurrences in related files:"
rg --type scss "max-width" src/main/webapp/app/overview/course-conversations

# Test 2: Check for any hardcoded widths that might conflict
echo "Checking for hardcoded widths that might conflict:"
rg --type scss "width:\s*\d+px" src/main/webapp/app/overview/course-conversations

# Test 3: Look for any media queries that might affect the new max-width
echo "Searching for media queries that might affect the new max-width:"
rg --type scss "@media" src/main/webapp/app/overview/course-conversations

Length of output: 700

Script:

#!/bin/bash
# Description: Check for potential conflicts with the new max-width using file patterns

# Test 1: Search for other occurrences of max-width in related .scss files
echo "Searching for other max-width occurrences in related files:"
rg --glob "*.scss" "max-width" src/main/webapp/app/overview/course-conversations

# Test 2: Check for any hardcoded widths that might conflict in .scss files
echo "Checking for hardcoded widths that might conflict:"
rg --glob "*.scss" "width:\s*\d+px" src/main/webapp/app/overview/course-conversations

# Test 3: Look for any media queries that might affect the new max-width in .scss files
echo "Searching for media queries that might affect the new max-width:"
rg --glob "*.scss" "@media" src/main/webapp/app/overview/course-conversations

Length of output: 3431


.postings-container {
display: flex;
Expand Down Expand Up @@ -37,6 +38,7 @@ $thread-section-card-min-width: 420px;
.card {
width: inherit;
min-width: $thread-section-card-min-width;
max-width: $thread-section-card-max-width;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

LGTM: Appropriate use of the new variable. Consider a minor improvement.

The new max-width property using $thread-section-card-max-width is correctly implemented and should effectively prevent content overflow as intended. This change, combined with the existing min-width, creates a constrained range for the card width, which is a good approach.

For consistency, consider moving the max-width property right after the min-width property. This would group related properties together, improving code readability.

Here's a suggested minor refactor for improved readability:

 .card {
     width: inherit;
     min-width: $thread-section-card-min-width;
+    max-width: $thread-section-card-max-width;
-
-    max-width: $thread-section-card-max-width;

     .card-header {
         justify-content: space-between;
         align-items: center;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
max-width: $thread-section-card-max-width;
min-width: $thread-section-card-min-width;
max-width: $thread-section-card-max-width;


.card-header {
justify-content: space-between;
Expand Down
Loading