Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Add status bar to lecture creation and edit mode #9655

Draft
wants to merge 51 commits into
base: develop
Choose a base branch
from

Conversation

florian-glombik
Copy link
Contributor

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

We do currently have the guided mode for the creation of lectures, however, we consider the approach used for the creation of exercises (status bar that allows you to scroll to sections and displays the current state of these sections) as more user friendly than the current guided mode.

Description

  • Introduce the status bar to the lecture create + edit view
  • Remove the current guided mode

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with Complaints enabled
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. ...

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

@florian-glombik florian-glombik self-assigned this Nov 2, 2024
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Nov 2, 2024
@florian-glombik florian-glombik added lecture Pull requests that affect the corresponding module and removed tests client Pull requests that update TypeScript code. (Added Automatically!) labels Nov 2, 2024
# Conflicts:
#	src/main/webapp/app/lecture/lecture-attachments.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/create-exercise-unit/create-exercise-unit.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/online-unit-form/online-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/text-unit-form/text-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-update.component.ts
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.html
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.ts
#	src/main/webapp/app/shared/form/title-channel-name/title-channel-name.component.ts
@github-actions github-actions bot added tests and removed lecture Pull requests that affect the corresponding module labels Nov 8, 2024
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) lecture Pull requests that affect the corresponding module labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) lecture Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!) tests user interface
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

1 participant