Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink support #642

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Hyperlink support #642

merged 4 commits into from
Apr 13, 2022

Conversation

meain
Copy link
Member

@meain meain commented Mar 27, 2022

Fixes #192 . There is still some more code cleanup left, but thought I would push the what I had so far.

Thanks to @KSXGitHub for the original implementation in #354.

2022-03-27-13-28-40


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@meain meain requested a review from Peltoche as a code owner March 27, 2022 07:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #642 (4fd803f) into master (7e49ca7) will increase coverage by 0.08%.
The diff coverage is 86.27%.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   86.43%   86.52%   +0.08%     
==========================================
  Files          39       40       +1     
  Lines        4240     4372     +132     
==========================================
+ Hits         3665     3783     +118     
- Misses        575      589      +14     
Impacted Files Coverage Δ
src/core.rs 0.00% <0.00%> (ø)
src/main.rs 7.69% <ø> (ø)
src/meta/mod.rs 41.40% <0.00%> (+0.32%) ⬆️
src/meta/name.rs 90.56% <78.00%> (-2.33%) ⬇️
src/display.rs 76.11% <88.46%> (+1.31%) ⬆️
src/flags/hyperlink.rs 98.52% <98.52%> (ø)
src/app.rs 74.62% <100.00%> (+0.38%) ⬆️
src/config_file.rs 70.00% <100.00%> (+0.33%) ⬆️
src/flags.rs 100.00% <100.00%> (ø)
src/meta/inode.rs 62.50% <0.00%> (-6.25%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e49ca7...4fd803f. Read the comment docs.

@meain
Copy link
Member Author

meain commented Apr 10, 2022

I have some cleanup left in this, but have been a bit busy the past few weeks. Hope to compete this soon.

@meain
Copy link
Member Author

meain commented Apr 13, 2022

This should be good to go now, there is some possible flags rework we could do, but I think I'll take that up later once I have a concrete idea. https://github.com/Peltoche/lsd/blob/ca5d9b3e160b0d9e6e1f1d2717e9df7cc51814e4/src/core.rs#L56

doc/lsd.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hyperlink rendering
4 participants