Retire lib/abcresub and abc_index_list #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 83.53% 83.47% -0.07%
==========================================
Files 187 187
Lines 29855 29692 -163
==========================================
- Hits 24938 24784 -154
+ Misses 4917 4908 -9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
abcresublibrary (extracted code from ABC) was added into mockturtle for comparison and experimental purposes. Its functionality is now fully subsumed by the native XAG resynthesis engine (algorithms/resyn_engines/xag_resyn.hpp/xag_resyn_decompose) and the latter should be used instead. Thus, abcresub is retired to reduce mockturtle's dependencies. The associated utility classabc_index_listis retired as well.