Replace #defines with C++ constants and inline functions in exor.h
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ABC is building this code in C translation units so I have to do this differently in a C-compatible way. |
rocallahan
force-pushed
the
exor-defines
branch
from
74f938b
to
276bc79
Compare
|
Not sure what happened to the Mac GCC11 build in CI, but everything else seems fine and ready for review. This is basically berkeley-abc/abc@3286179 |
No viable platform uses anything other than 32 bits for `int`.
This avoids issues with short/common identifiers like `BPI` and `DIFFERENT` colliding with identifiers used in other projects.
rocallahan
force-pushed
the
exor-defines
branch
from
e8b45a0
to
ce24711
Compare
|
@aletempiac can you please take a look at this? I landed this in upstream ABC a while back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#definefor short/common names likeBPIandDIFFERENTcan break the build when #included alongside unrelated code that uses those identifiers.I have also removed the code that supports
intsizes other than 32 bits. There aren't any viable architectures whereintis not 32 bits.