Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prevRouterProps from shouldUpdateScroll #50

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

misioq23
Copy link
Contributor

  1. prevRouterProps's location cause an error when address contains section path e.g type: localhost:8000/#test
  2. prevRouterProps is unused in project

1. prevRouterProps's location cause an error when address contains section path e.g type: localhost:8000/#test
2. prevRouterProps is unused in project
@lsirivong
Copy link
Owner

Hi @misioq23 thanks for the contribution!

I understand that this can be removed because it's an unused variable, but could you help me understand what you mean by "prevRouterProps's location cause an error when address contains section path"? What is the error that occurs, and how does this address that?

@misioq23
Copy link
Contributor Author

Hi @lsirivong, you are welcome!

I created simple repo.

  1. Run gatsby develop
  2. put localhost:8000/#second into the address bar (or another section id)
  3. "TypeError: Cannot read property 'location' of undefined" occurs

@chardmd
Copy link

chardmd commented Jun 28, 2020

@lsirivong, here's the screenshot of the error.

Screenshot 2020-06-28 at 3 06 11 PM

@lsirivong lsirivong merged commit fd9f068 into lsirivong:master Jun 28, 2020
@lsirivong
Copy link
Owner

Thanks folks, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants