Merge pull request #10 from lsportsltd/fix/kafka-without-topics

fixed curator crashing when there are no existing topics found
lsportsltd · Aug 27, 2024 · 8ccfaa8 · 8ccfaa8
2 parents 9c7b6c6 + d5c49b7
commit 8ccfaa8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -2,8 +2,8 @@
 # kafka-curator
 
 # Introduction
-- KafkaCurator was designed to provide a simple and suprevised way to manage everything related to Kafka topics.
-- Alot of the code in this library was inspired by [KafkaFlow](https://github.com/Farfetch/kafkaflow).
+- KafkaCurator was designed to provide a simple and supervised way to manage everything related to Kafka topics.
+- A lot of the code in this library was inspired by [KafkaFlow](https://github.com/Farfetch/kafkaflow).
 
 # Getting Started
 ## Requirements

diff --git a/src/KafkaCurator/State/DefaultStateManager.cs b/src/KafkaCurator/State/DefaultStateManager.cs
@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
@@ -34,6 +35,7 @@ private async Task<IReadOnlyList<ITopicConfiguration>> GetTopicMetadata()
         {
             var topicsMetadata = _adminClient.GetMetadata(_configuration.Timeout).Topics
                 .ToDictionary(t => t.Topic, t => t);
+            if (topicsMetadata.Keys.Count == 0) return new List<ITopicConfiguration>().AsReadOnly();
 
             var topicsConfigResults = await DescribeTopicConfigAsync(topicsMetadata.Keys);