DM-44606: Drop pydantic-settings from worker, add timeout #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a separate, minimal UWSWorkerConfig dataclass containing the information needed to construct the backend worker, and modify the worker initialization so that it no longer needs to load the main vo-cutouts Config and thus doesn't depend on pydantic-settings. Plumb execution_duration in the UWS configuration through to the arq worker configuration so that we at least impose the maximum execution duration limit on worker execution. Supporting the per-job configuration will require more work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate, minimal UWSWorkerConfig dataclass containing the information needed to construct the backend worker, and modify the worker initialization so that it no longer needs to load the main vo-cutouts Config and thus doesn't depend on pydantic-settings.
Plumb execution_duration in the UWS configuration through to the arq worker configuration so that we at least impose the maximum execution duration limit on worker execution. Supporting the per-job configuration will require more work.