DM-44720: Improve serialization of task errors #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive `TaskError` from `SlackException` so that eventually we can report unexpected errors to Slack. Rely on `SlackException` to handle serialization support, which is currently on a Safir branch. Add support for including a traceback of the cause of a `TaskError` exception, and enable that for exceptions from the image cutout backend. Hopefully those exceptions will not contain any security-sensitive information.
Try the test branch of image_cutout_backend and see if it fixes various deprecation warnings.
rra
force-pushed
the
tickets/DM-44720
branch
2 times, most recently
from
de22c9d
to
a86b322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive
TaskErrorfromSlackExceptionso that eventually we can report unexpected errors to Slack. Rely onSlackExceptionto handle serialization support, which is currently on a Safir branch.Add support for including a traceback of the cause of a
TaskErrorexception, and enable that for exceptions from the image cutout backend. Hopefully those exceptions will not contain any security-sensitive information.