DM-44763: Reflect the lack of job cancellation support #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, there is no way to cancel a sync worker job within arq. ThreadPoolWorker does not offer this functionality, nor does ProcessPoolWorker. We would have to implement our own execution protocol in an external process that we could kill, which would pose cleanup problems. Reflect this by removing the configuration option for setting a job timeout and forcing the UWS executionduration to 0 by default unless the service supplies a validator for it (in case there are services where the sync backend supports an explicit timeout parameter). Also remove the vestiges of support for aborting a job, since there is no way to do that either given our worker implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there is no way to cancel a sync worker job within arq. ThreadPoolWorker does not offer this functionality, nor does ProcessPoolWorker. We would have to implement our own execution protocol in an external process that we could kill, which would pose cleanup problems.
Reflect this by removing the configuration option for setting a job timeout and forcing the UWS executionduration to 0 by default unless the service supplies a validator for it (in case there are services where the sync backend supports an explicit timeout parameter).
Also remove the vestiges of support for aborting a job, since there is no way to do that either given our worker implementation.