DM-45138: Switch to vo-models where possible for UWS #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vo-models provides pydantic-xml models for, among other things, UWS. This supports serialization to XML without requiring a separate templating implementation. Use these models for UWS handler output where possible and remove the corresponding templates. This as yet doesn't support the handlers that return the full job and the parameters, since the cutout parameters are multivalued and this currently apparently cannot be modeled by vo-models. The corresponding tests now test equality of the pydantic-xml models instead of the XML text, but continue to use the XML from previous tests to compare against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vo-models provides pydantic-xml models for, among other things, UWS. This supports serialization to XML without requiring a separate templating implementation. Use these models for UWS handler output where possible and remove the corresponding templates.
This as yet doesn't support the handlers that return the full job and the parameters, since the cutout parameters are multivalued and this currently apparently cannot be modeled by vo-models.
The corresponding tests now test equality of the pydantic-xml models instead of the XML text, but continue to use the XML from previous tests to compare against.