DM-45281: Convert to the Safir UWS library #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the UWS support library has been incorporated into Safir, switch to using the Safir version, including the new testing framework.
We use the middleware that lowercases all query keys, so there's no need to explicitly do so in the dependency.
Configuring logging for the backend worker requires safir.logging be installed, which we cannot guarantee is present in the backend stack container. Remove the configuration for now pending a discussion about the best way to handle logging from arq.
Remove the standard UWS settings from Config in favor of inheriting from UWSAppSettings. Use its build_uws_config method to construct the UWS configuration.
Rather than manually installing the case-insensitive middleware, use the new UWSApplication method to install all needed middleware.
Switch to a different ticket branch in Safir where the UWS library support is awaiting final approval.
The backend uses structlog for logging and that is alas not part of a stack container, so we have to install it with pip.
The remote Butler requires httpx, but it's not part of the pipelines base container.
In preparation for the new Safir release, start testing from the main branch instead of a ticket branch.
Safir 6.2.0 has been released with UWS library support. Update and regenerate dependencies accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the UWS support library has been incorporated into Safir, switch to using the Safir version, including the new testing framework.